Re: Fix for normalization of foreign idents

From: Marcus Comstedt <marcus@mc.pp.se>
Date: Aug 23, 2010, 21:44 UTC
Message-ID: <yf97hjhrol5.fsf@chiyo.mc.pp.se>
In-Reply-To: <20100823213531.GD2120@burratino>

Hi Jonathan.

Thanks for the quick feedback.

Jonathan Nieder <jrnieder@gmail.com> writes:

> I was with you up to here.  Is commit time really the right moment
> to clobber a foreign ident?  I suspect it would be confusing.

Well, it's how ident is normally expected to behave; when you commit something new, the file should get a new ident.

> It might be simpler to just never clobber a foreign ident and instead
> rely on local policy (scripts, pre-commit hooks, and so on) to remove
> them at the appropriate time.

Simpler as far as patch size is concerned (although this patch isn't really that complex as it is), but it sounds like much more of a hassle to actually use. Do you have a use case in mind where you have the ident attribute on a file but do _not_ want a new ident each time you commit a change to the file?

  // Marcus