Re: [PATCH v2 1/2] convert: fix normalization of foreign idents

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 12, 2010, 21:44 UTC
Message-ID: <7vd3sid4bo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <yf9hbhuisla.fsf@chiyo.mc.pp.se>

Marcus Comstedt <marcus@mc.pp.se> writes:

Show 8 quoted lines

>> It also smells wrong that this "sometimes we convert, sometimes we don't"
>> is a special case for "$Id$" and for no other conversion.  Why don't
>> smudge/clean filter or CRLF conversion have the same issue that can be
>> solved with the same approach as this patch takes?
>
> I gather that this is because nobody has come up with a use case
> for smudge/clean or CRLF where a (pervasive) non-normalized
> representation in the repository makes sense.

Think a bit more about what you just wrote means.

Imagine there isn't any "$Id$" (or "$ident$" as it was originally known) expansion in git. You can implement it easily using a smudge/clean pair, and the smudge and clean should be conditionally applied in the codepath you touched using exactly the same logic as your patch uses, no?

That is what I meant. It smells wrong to make this "sometime we do, sometimes we don't" as a special case for "$Id$". Specifically, the parameter name "normalize_foreign_ident" feels wrong; the concept that the parameter tries to convey covers much wider than just "foreign ident", no?