[PATCH] templates/Makefile: install is unnecessary, just use mkdir -p
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Aug 22, 2008, 00:31 UTC
- Message-ID
- <y-OStBu9jZ4ghBeO7Duf6UrkhSEZFsB9o5V_P-EgCcq3k1diXe1EAA@cipher.nrlssc.navy.mil>
- In-Reply-To
- <7vhc9hlwt3.fsf@gitster.siamese.dyndns.org>
From: Junio C Hamano <gitster@pobox.com>
The native install on some platforms (namely IRIX 6.5) treats non-absolute paths as being relative to the root directory rather than relative to the current directory. Work around this by avoiding install in this case since it is unnecessary, and instead depend on the local umask setting and use mkdir.
Tested-by: Brandon Casey <casey@nrlssc.navy.mil> ---
Junio C Hamano wrote:
> I do not see absolutely any reason to use install there. > > I have to wonder why 9907721 (templates/Makefile: don't depend on local > umask setting, 2008-02-28) did not do this instead:
works for me.
-brandon
templates/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/templates/Makefile b/templates/Makefile index cc3fc30..0722a92 100644 --- a/templates/Makefile +++ b/templates/Makefile @@ -23,13 +23,13 @@ all: boilerplates.made custom bpsrc = $(filter-out %~,$(wildcard *--*)) boilerplates.made : $(bpsrc) - $(QUIET)ls *--* 2>/dev/null | \ + $(QUIET)umask 022 && ls *--* 2>/dev/null | \ while read boilerplate; \ do \ case "$$boilerplate" in *~) continue ;; esac && \ dst=`echo "$$boilerplate" | sed -e 's|^this|.|;s|--|/|g'` && \ dir=`expr "$$dst" : '\(.*\)/'` && \ - $(INSTALL) -d -m 755 blt/$$dir && \ + mkdir -p blt/$$dir && \ case "$$boilerplate" in \ *--) ;; \ *) cp -p $$boilerplate blt/$$dst ;; \
-- 1.6.0.21.g35a2e