Re: [PATCH] templates/Makefile: work around SGI install which assumes / if ROOT not defined

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 18, 2008, 23:37 UTC
Message-ID: <7vhc9hlwt3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <XAO6w2f4AxtqGEL6HNTkRYjhSFFUavQK8LYfdASEGw3-LRoH4_7Cdg@cipher.nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

Show 10 quoted lines

> diff --git a/templates/Makefile b/templates/Makefile
> index 9f3f1fc..3ea63e1 100644
> --- a/templates/Makefile
> +++ b/templates/Makefile
> @@ -29,7 +29,7 @@ boilerplates.made : $(bpsrc)
>  		case "$$boilerplate" in *~) continue ;; esac && \
>  		dst=`echo "$$boilerplate" | sed -e 's|^this|.|;s|--|/|g'` && \
>  		dir=`expr "$$dst" : '\(.*\)/'` && \
> -		$(INSTALL) -d -m 755 blt/$$dir && \
> +		ROOT=./ $(INSTALL) -d -m 755 blt/$$dir && \

I do not see absolutely any reason to use install there.

I have to wonder why 9907721 (templates/Makefile: don't depend on local umask setting, 2008-02-28) did not do this instead:

	$(QUIET)umask 022 && ls *--* 2>/dev/null | \
	while read boilerplate; \
	do \
		case "$$boilerplate" in *~) continue ;; esac && \
		dst=`echo "$$boilerplate" | sed -e 's|^this|.|;s|--|/|g'` && \
		dir=`expr "$$dst" : '\(.*\)/'` && \
		mkdir -p blt/$$dir && \
		case "$$boilerplate" in \
		*--) ;; \
		*) cp $$boilerplate blt/$$dst ;; \
		esac || exit; \
	done && \
	date >$@