Re: [PATCH 2/3] ci: update Perforce version to r23.2

From: Justin Tobler <jltobler@gmail.com>
Date: Jul 30, 2024, 22:48 UTC
Message-ID: <xy2vh6bv6sjixvwd6fifuctozjizxns5evvgnqee5s6snnzb36@5hhtwvdk2a36>
In-Reply-To: <ee5d836b779087890acdad061ef6995642942479.1721740612.git.ps@pks.im>

On 24/07/23 04:05PM, Patrick Steinhardt wrote:

> Update our Perforce version from r21.2 to r23.2. Note that the updated
> version is not the newest version. Instead, it is the last version where
> the way that Perforce is being distributed remains the same as in r21.2.
> Newer releases stopped distributing p4 and p4d executablesas well as the

s/executablesas/executables as/

> macOS archives directly and would thus require more work.

Out of curiousity, for Perforce is there a defined range of versions that the Git project supports? I guess I'm trying to figure if it even makes sense to support older version of Perforce in our tests.

Show 22 quoted lines

> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  ci/install-dependencies.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 6ec0f85972..b59fd7c1fd 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -7,7 +7,7 @@
>  
>  begin_group "Install dependencies"
>  
> -P4WHENCE=https://cdist2.perforce.com/perforce/r21.2
> +P4WHENCE=https://cdist2.perforce.com/perforce/r23.2
>  LFSWHENCE=https://github.com/github/git-lfs/releases/download/v$LINUX_GIT_LFS_VERSION
>  JGITWHENCE=https://repo.eclipse.org/content/groups/releases//org/eclipse/jgit/org.eclipse.jgit.pgm/6.8.0.202311291450-r/org.eclipse.jgit.pgm-6.8.0.202311291450-r.sh
>  
> -- 
> 2.46.0.rc1.dirty
>