Re: [PATCH v2 0/3] Improvements for Perforce tests

From: Justin Tobler <jltobler@gmail.com>
Date: Jul 31, 2024, 20:50 UTC
Message-ID: <na5mwletzpnacietbc7pzqcgb622mvrwgrkjgjosysz3gvjcso@gzxxi7d7icr7>
In-Reply-To: <cover.1722421911.git.ps@pks.im>

On 24/07/31 12:37PM, Patrick Steinhardt wrote:

Show 13 quoted lines

> Hi,
> 
> this is the second version of my patch series that improves Perforce
> tests a bit. As with the first version, the main intent is to mark all
> tests as leak free. The other two patches polish the Perforce tests such
> that they work on my machine, which has a more recent version of
> Perforce than what we have been testing with in CI.
> 
> As discussed, despite these patches I consider Perforce to be basically
> unmaintained, and my patches do not change that. But given that I don't
> think we can rip out git-p4(1) just so without any kind of announcement
> up front, I still think that these patches are worth it to help my own
> cause, namely plugging all memory leaks hit by tests in Git.

Agreed that proposing a removal of git-p4(1) is more of a separate issue here. For now, these patches make sense so we can get closer to making the tests memory leak free. :)

Show 11 quoted lines

> 
> Changes compared to v1:
> 
>   - Fix some typos.
> 
>   - Add in-code comments explaining what the compatibility case
>     statements are about.
> 
> Thanks!
> 
> Patrick

From looking at the range diff, this version looks good to me. Thanks

-Justin