Re: [PATCH 2/3] setup_pager: set MORE=R
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 17, 2014, 19:11 UTC
- Message-ID
- <xmqqzjmuwhi7.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <398F146D-72F1-44CD-B205-729665FD8765@gmail.com>
"Kyle J. McKay" <mackyle@gmail.com> writes:
Show 20 quoted lines
> On Jan 16, 2014, at 20:21, Jeff King wrote:
>> When we run the pager, we always set "LESS=R" to tell the
>> pager to pass through ANSI colors. On modern versions of
>> FreeBSD, the system "more" can do the same trick.
> [snip]
>> diff --git a/pager.c b/pager.c
>> index 90d237e..2303164 100644
>> --- a/pager.c
>> +++ b/pager.c
>> @@ -87,6 +87,10 @@ void setup_pager(void)
>> argv_array_push(&env, "LESS=FRSX");
>> if (!getenv("LV"))
>> argv_array_push(&env, "LV=-c");
>> +#ifdef PAGER_MORE_UNDERSTANDS_R
>> + if (!getenv("MORE"))
>> + argv_array_push(&env, "MORE=R");
>> +#endif
>
> How about adding a leading "-" to both the LESS and MORE settings?
> Since you're in there patching... :)The discussion we had when LV=-c was added, namely $gmane/240124, agrees. I however am perfectly fine to see it done as a separate clean-up patch.