git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 'git log' escape symbols shown as ESC[33 and ESC[m

From
Jeff King <peff@peff.net>
Date
Jan 17, 2014, 02:35 UTC
Message-ID
<20140117023548.GB13023@sigill.intra.peff.net>
In-Reply-To
<20140117022921.GU18964@google.com>
On Thu, Jan 16, 2014 at 06:29:21PM -0800, Jonathan Nieder wrote:
Show 11 quoted lines
> > +	/*
> > +	 * We know that "more" does not pass through colors at all.
> > +	 */
> > +	if (!strcmp(pager, "more"))
> > +		return 0;
> 
> I seem to remember that on some systems "more" is the name of the
> full-featured pager that knows how to scroll forward and backward and
> handle color.  (My memory could be faulty.  A search in the makefile
> for DEFAULT_PAGER=more only finds AIX, which is not the platform I was
> thinking of.)

Yeah, my "we know" here was still guessing. According to Yuri, FreeBSD is the system you are thinking of. :)

> On a stock Debian system "more" is especially primitive, which means
> that it passes colors through, too.  It being so primitive also means
> it is not a particularly good choice for the PAGER setting, though,
> so probably that's not too important.

Yeah, colors do get passed through on Debian. It's possible that other primitive "more" implementations are OK, too (and certainly we have defaulted to "on" for them until now).

I think we should make an effort to set MORE=R on FreeBSD. We can perhaps just set it unconditionally, and assume that primitive "more" will ignore it. And then assume that "more" will handle colors (either because of the R setting, or because it is too dumb to escape it).

I can prepare a patch series, but I happily no longer have any antique systems to test this kind of stuff on.

-Peff
Previous: Jonathan NiederNext: Jeff King
Message 9 of 39 in “'git log' escape symbols shown as ESC[33 and ESC[m”
  1. YuriJan 17, 2014
  2. Jeff KingJan 17, 2014
  3. YuriJan 17, 2014
  4. Jeff KingJan 17, 2014
  5. YuriJan 17, 2014
  6. Jeff KingJan 17, 2014
  7. YuriJan 17, 2014
  8. Jonathan NiederJan 17, 2014
  9. Jeff KingJan 17, 2014
  10. Jeff KingJan 17, 2014
  11. 0/3 improved out-of-the-box color settingsJeff King, Jan 17, 2014
  12. 1/3 setup_pager: refactor LESS/LV environment settingJeff King, Jan 17, 2014
  13. 2/3 setup_pager: set MORE=RJeff King, Jan 17, 2014
  14. Kyle J. McKayJan 17, 2014
  15. Junio C HamanoJan 17, 2014
  16. Jeff KingJan 21, 2014
  17. Kyle J. McKayJan 21, 2014
  18. Jeff KingJan 23, 2014
  19. Junio C HamanoJan 23, 2014
  20. Junio C HamanoJan 17, 2014
  21. Junio C HamanoJan 17, 2014
  22. Junio C HamanoJan 17, 2014
  23. Jeff KingJan 21, 2014
  24. Junio C HamanoJan 21, 2014
  25. Jeff KingJan 21, 2014
  26. Junio C HamanoJan 21, 2014
  27. Jeff KingFeb 4, 2014
  28. Junio C HamanoFeb 4, 2014
  29. Jeff KingFeb 4, 2014
  30. YuriFeb 4, 2014
  31. Jeff KingFeb 4, 2014
  32. Junio C HamanoFeb 4, 2014
  33. YuriFeb 4, 2014
  34. Kyle J. McKayFeb 5, 2014
  35. 3/3 pager: disable colors for some known-bad configurationsJeff King, Jan 17, 2014
  36. YuriJan 17, 2014
  37. YuriJan 17, 2014
  38. YuriFeb 5, 2014
  39. Jeff KingFeb 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.