git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/9] add --gpg-sign to rebase and pull

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 24, 2014, 20:06 UTC
Message-ID
<xmqqzjmlqh5a.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140124091444.GM10748@mars-attacks.org>
Nicolas Vigier <boklm@mars-attacks.org> writes:
Show 13 quoted lines
> On Fri, 24 Jan 2014, brian m. carlson wrote:
>
>> This series was posted to the list some time back, but it fell through
>> the cracks.  This is a re-send of Nicolas Vigier's work with an
>> additional patch that adds --gpg-sign to pull as well.  I added my
>> sign-off to his patches because SubmittingPatches (section (c)) seems to
>> imply that I should, although I can rebase it out if it's a problem.
>
> Thanks!
>
> An improvement I was thinking to do on this series but had not time to
> do yet is to make the '--no-gpg-sign' option disable gpg signing when
> the commit.gpgsign config option is set to true.

By the way, a configuration variable that has no way of getting overriden per invocation should not exist without a very good reason ("core.bare" is an example of a exception with a good reason---the bareness of the repository does not change per command invocation). An escape hatch "--no-gpg-sign" is a must-have requirement, not a nice-to-have improvement.

Thanks for not forgetting.
Previous: Nicolas Vigier
Message 22 of 22 in “add --gpg-sign to rebase and pull”
  1. 0/9 add --gpg-sign to rebase and pullbrian m. carlson, Jan 24, 2014
  2. 1/9 cherry-pick, revert: add the --gpg-sign optionbrian m. carlson, Jan 24, 2014
  3. Junio C HamanoJan 24, 2014
  4. brian m. carlsonJan 24, 2014
  5. Junio C HamanoJan 24, 2014
  6. 2/9 git-sh-setup.sh: add variable to use the stuck-long modebrian m. carlson, Jan 24, 2014
  7. Junio C HamanoJan 27, 2014
  8. 3/9 am: parse options in stuck-long modebrian m. carlson, Jan 24, 2014
  9. 4/9 am: add the --gpg-sign optionbrian m. carlson, Jan 24, 2014
  10. Junio C HamanoJan 27, 2014
  11. 5/9 rebase: remove useless arguments checkbrian m. carlson, Jan 24, 2014
  12. 6/9 rebase: don't try to match -M optionbrian m. carlson, Jan 24, 2014
  13. 7/9 rebase: parse options in stuck-long modebrian m. carlson, Jan 24, 2014
  14. 8/9 rebase: add the --gpg-sign optionbrian m. carlson, Jan 24, 2014
  15. Junio C HamanoJan 27, 2014
  16. brian m. carlsonJan 27, 2014
  17. 9/9 pull: add the --gpg-sign option.brian m. carlson, Jan 24, 2014
  18. Junio C HamanoJan 27, 2014
  19. brian m. carlsonFeb 1, 2014
  20. Junio C HamanoFeb 3, 2014
  21. Nicolas VigierJan 24, 2014
  22. Junio C HamanoJan 24, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.