Re: [PATCH v2 2/9] git-sh-setup.sh: add variable to use the stuck-long mode

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 27, 2014, 23:21 UTC
Message-ID: <xmqqtxcpm2ou.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1390524666-51274-3-git-send-email-sandals@crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 13 quoted lines

> From: Nicolas Vigier <boklm@mars-attacks.org>
>
> If the variable $OPTIONS_STUCKLONG is not empty, then rev-parse
> option parsing is done in --stuck-long mode.
>
> Signed-off-by: Nicolas Vigier <boklm@mars-attacks.org>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>  contrib/examples/git-checkout.sh | 1 +
>  contrib/examples/git-clean.sh    | 1 +
>  contrib/examples/git-clone.sh    | 1 +
>  contrib/examples/git-merge.sh    | 1 +
>  contrib/examples/git-repack.sh   | 1 +

Hmmm, especially given that nobody is exercising the ``updated'' code even in our testsuite, is it a good idea to touch these?

The STUCKLONG never existed back when they were scripted. It just adds noise when trying to view them for hints, no?

Show 13 quoted lines

> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
> index fffa3c7..5f28b32 100644
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -72,6 +72,8 @@ if test -n "$OPTIONS_SPEC"; then
>  	parseopt_extra=
>  	[ -n "$OPTIONS_KEEPDASHDASH" ] &&
>  		parseopt_extra="--keep-dashdash"
> +	[ -n "$OPTIONS_STUCKLONG" ] &&
> +		parseopt_extra="$parseopt_extra --stuck-long"
>  
>  	eval "$(
>  		echo "$OPTIONS_SPEC" |