Re: [PATCH] configure.ac: link with -liconv for locale_charset()

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 20, 2014, 21:12 UTC
Message-ID: <xmqqzjkkwp4f.fsf@gitster.dls.corp.google.com>
In-Reply-To: <531F902D.4050102@aegee.org>

Дилян Палаузов  <dilyan.palauzov@aegee.org> writes:

Show 16 quoted lines

> diff --git a/Makefile b/Makefile
> index dddaf4f..dce4694 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -59,9 +59,9 @@ all::
>  # FreeBSD can use either, but MinGW and some others need to use
>  # libcharset.h's locale_charset() instead.
>  #
> -# Define CHARSET_LIB to you need to link with library other than -liconv to
> +# Define CHARSET_LIB to the library you need to link with in order to
>  # use locale_charset() function.  On some platforms this needs to set to
> -# -lcharset
> +# -lcharset, on others to -liconv .
>  #
>  # Define LIBC_CONTAINS_LIBINTL if your gettext implementation doesn't
>  # need -lintl when linking.

This was unfortunately lost in the noise and I missed it. I think the updated text is much more clear than the original.

Thanks.