git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] configure.ac: link with -liconv for locale_charset()

From
Dmitry Marakasov <amdmi3@amdmi3.ru>
Date
Mar 11, 2014, 22:39 UTC
Message-ID
<20140311223942.GD11801@hades.panopticon>
In-Reply-To
<xmqqsiqoo4ma.fsf@gitster.dls.corp.google.com>
* Junio C Hamano (gitster@pobox.com) wrote:
Show 19 quoted lines
> > On e.g. FreeBSD 10.x, the following situation is common:
> > - there's iconv implementation in libc, which has no locale_charset()
> >   function
> > - there's GNU libiconv installed from Ports Collection
> >
> > Git build process
> > - detects that iconv is in libc and thus -liconv is not needed for it
> > - detects locale_charset in -liconv, but for some reason doesn't add it
> >   to CHARSET_LIB (as it would do with -lcharset if locale_charset() was
> >   found there instead of -liconv)
> > - git doesn't build due to unresolved external locale_charset()
> >
> > Fix this by adding -liconv to CHARSET_LIB if locale_charset() is
> > detected in this library.
> >
> > Signed-off-by: Dmitry Marakasov <amdmi3@amdmi3.ru>
> > ---
> 
> Looks sensible; Dilyan, any comments?
Addendum: build logs before and after the fix:

http://people.freebsd.org/~amdmi3/git-iconv-fail.log http://people.freebsd.org/~amdmi3/git-iconv-fixed.log

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Previous: Junio C HamanoNext: Dmitry Marakasov
Message 5 of 6 in “configure.ac: link with -liconv for locale_charset()”
  1. configure.ac: link with -liconv for locale_charset()Dmitry Marakasov, Mar 11, 2014
  2. Junio C HamanoMar 11, 2014
  3. Дилян ПалаузовMar 11, 2014
  4. Junio C HamanoMar 20, 2014
  5. Dmitry MarakasovMar 11, 2014
  6. Dmitry MarakasovMar 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.