Re: [PATCH] imap-send: clarify CRAM-MD5 vs LOGIN documentation

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 30, 2014, 19:28 UTC
Message-ID: <xmqqzjfqy7br.fsf@gitster.dls.corp.google.com>
In-Reply-To: <alpine.LSU.2.00.1407281138100.13901@hermes-1.csi.cam.ac.uk>

Tony Finch <dot@dotat.at> writes:

Show 20 quoted lines

> Explicitly mention that leaving imap.authMethod unset makes
> git imap-send use the basic IMAP plaintext LOGIN command.
> ---
>  Documentation/git-imap-send.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt
> index 875d283..770cbe8 100644
> --- a/Documentation/git-imap-send.txt
> +++ b/Documentation/git-imap-send.txt
> @@ -76,7 +76,8 @@ imap.preformattedHTML::
>
>  imap.authMethod::
>  	Specify authenticate method for authentication with IMAP server.
> -	Current supported method is 'CRAM-MD5' only.
> +	Current supported method is 'CRAM-MD5' only. If this is not set
> +	then 'git imap-send' uses the basic IMAP plaintext LOGIN command.
>
>  Examples
>  ~~~~~~~~

Both patches make sense to me, but can you please sign-off your patches? See Documentation/SubmittingPatches for details.

Thanks.