Re: [PATCH v3 2/2] imap-send: create target mailbox if it is missing

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 3, 2014, 06:38 UTC
Message-ID: <CAPc5daWPiCj7Uap4J+AOfebYYVewhnQX-pbT=ByuzOE-K2tA_A@mail.gmail.com>
In-Reply-To: <53DCEB4A.1030009@ramsay1.demon.co.uk>

Yup. I think I also queued a fix-up on top. Thanks for reporting.

On Sat, Aug 2, 2014 at 6:44 AM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 24 quoted lines

> On 01/08/14 23:30, Junio C Hamano wrote:
>> Tony Finch <dot@dotat.at> writes:
>>
>>> Some MUAs delete their "drafts" folder when it is empty, so
>>> git imap-send should be able to create it if necessary.
>>
>> Thanks for an update; queued.
>
> BTW, this provokes a warning from gcc (v4.8.2) for me:
>
>         CC imap-send.o
>     imap-send.c:561:25: warning: ‘issue_imap_cmd’ defined but not used [-Wunused-function]
>      static struct imap_cmd *issue_imap_cmd(struct imap_store *ctx,
>                              ^
> It seems the change to get_cmd_result(), in commit 7ebac713, removes
> the only remaining (two) calls to issue_imap_cmd().
>
> HTH
>
> ATB,
> Ramsay Jones
>
>
>