Re: [PATCH] completion: remove credential helpers from porcelain commands
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 5, 2015, 21:36 UTC
- Message-ID
- <xmqqzj5id7v7.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20150505200607.GB12067@peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
>> However, if you think filtering out 'credential-*' is the way to go, I'm >> happy to reroll. > > I'd actually be fine with just marking all credential-* as "credentials > helper". I think we have staked out the "git-credential-foo" namespace, > so anybody putting something unrelated in there deserves what they get. > And it makes one fewer list to keep up to date. > > I _do_ have other git-credential-foo's that should be ignored (and are > not in your list), but I am probably the only person in the world (they > are due to me experimenting with the credential helper code :) ).
Let's do this on top of the "typofix helper" one, as there was another show-stopper typo. I could also amend the log message and declare that we now squat on git-credential-<anything>, but I do not think it is necessary.
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index fdf0ddc..af78212 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -665,13 +665,8 @@ __git_list_porcelain_commands () checkout-index) : plumbing;; commit-tree) : plumbing;; count-objects) : infrequent;; - credential : credentials;; - credential-cache) : credentials helper;; - credential-gnome-keyring) : credentials helper;; - credential-netrc) : credentials helper;; - credential-osxkeychain) : credentials helper;; - credential-store) : credentials helper;; - credential-wincred) : credentials helper;; + credential) : credentials;; + credential-*) : credentials helper;; cvsexportcommit) : export;; cvsimport) : import;; cvsserver) : daemon;;