[PATCH] completion: remove credential helpers from porcelain commands
- From
SZEDER Gábor <szeder@ira.uka.de>
- Date
- May 5, 2015, 13:19 UTC
- Message-ID
- <1430831972-6788-1-git-send-email-szeder@ira.uka.de>
Don't offer the "main" 'git credential' command or any of the credential helpers from contrib/credential/ when completing git commands.
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> ---
I was tempted to simply filter out 'credential-*', so we don't have to update this list when new credential helpers arrive. However, the 'git-credential-*' "namespace" is not explicitly reserved for credential helpers, users have to set the 'credential.helper' config variable to tell explicitly that 'git-credential-foo' should be used as credential helper, and who knows, someone might have his own 'git-credential-bar' command that does something completely unrelated to git's credential system, so in the end decided against it. And credential helpers don't pop up too frequently anyway.
However, if you think filtering out 'credential-*' is the way to go, I'm happy to reroll.
contrib/completion/git-completion.bash | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index e0eb6ae..527bb00 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -665,8 +665,13 @@ __git_list_porcelain_commands () checkout-index) : plumbing;; commit-tree) : plumbing;; count-objects) : infrequent;; + credential : credentials;; credential-cache) : credentials helper;; + credential-gnome-keyring) : credentials helpe;; + credential-netrc) : credentials helper;; + credential-osxkeychain) : credentials helper;; credential-store) : credentials helper;; + credential-wincred) : credentials helper;; cvsexportcommit) : export;; cvsimport) : import;; cvsserver) : daemon;;
-- 1.9.5.msysgit.0