Re: [PATCH v3 24/34] mailinfo: move content/content_top to struct mailinfo

> On Mon, Oct 19, 2015 at 12:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  builtin/mailinfo.c | 45 ++++++++++++++++++++++++++-------------------
>>  1 file changed, 26 insertions(+), 19 deletions(-)
>>
>> diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
>> index 2c194da..ec65805 100644
>> --- a/builtin/mailinfo.c
>> +++ b/builtin/mailinfo.c
>> @@ -7,6 +7,8 @@
>>  #include "utf8.h"
>>  #include "strbuf.h"
>>
>> +#define MAX_BOUNDARIES 5
>> +
>>  struct mailinfo {
>>         FILE *input;
>>         FILE *output;
>> @@ -22,6 +24,8 @@ struct mailinfo {
>>         int use_inbody_headers; /* defaults to 1 */
>>         const char *metainfo_charset;
>>
>> +       struct strbuf *content[MAX_BOUNDARIES];
>> +       struct strbuf **content_top;
>>         struct strbuf charset;
>>         char *message_id;
>>         enum  {
>> @@ -35,7 +39,6 @@ struct mailinfo {
>>  };
>>
>>  #define MAX_HDR_PARSED 10
>> -#define MAX_BOUNDARIES 5
>
> Would it make sense to also move MAX_HDR_PARSED, such that we have all
> defines in one place?