Re: [PATCH v3 14/34] mailinfo: move filter/header stage to struct mailinfo
- From
Stefan Beller <sbeller@google.com>
- Date
- Oct 21, 2015, 20:20 UTC
- Message-ID
- <CAGZ79kaCA5HLF7mLY9OC_JrZ9ZhfURdcLoZxQ4rMwmMyWHf_sg@mail.gmail.com>
- In-Reply-To
- <1445239731-10677-15-git-send-email-gitster@pobox.com>
On Mon, Oct 19, 2015 at 12:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> @@ -28,6 +31,7 @@ static enum {
>
> static struct strbuf charset = STRBUF_INIT;
> static int patch_lines;
> +nitpicking here. Why is this patch the best in series to introduce a new line at this position? ;)
Show 6 quoted lines
> static struct strbuf **p_hdr_data, **s_hdr_data; > static int use_scissors; > static int add_message_id; > @@ -718,25 +722,25 @@ static int is_scissors_line(const struct strbuf *line) > gap * 2 < perforation); > }