Re: [PATCH] verify-tag: allow to verify signed blob objects

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 15, 2016, 19:24 UTC
Message-ID: <xmqqziqm5k7j.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <9b700254-23b1-286c-70e6-68d484e9c4e8@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 11 quoted lines

>> Or even
>> 
>> 	if ((flags & GPG_VERIFY_BLOB) && (type != OBJ_BLOB))
>>                	"you told me to check blob but didn't give me one";
>> 	} else if (type != OBJ_TAG)
>> 		"you didn't give me a tag";
>> 
>
> I just tried to stay as close to the original as possible, but I don't
> care either way. Your latter version is more strict and would require a
> slight documentation change, but would be fine, too.

Actually, the message you reused is not reusable for this new mode. I guess starting from more strict (which makes sense, as you do not want to silently say "Yeah, the blob verifies OK" when the user tells you "I want you to verify this blob, and here it is" and hands you a tag. If that were an acceptable behaviour, you do not even need VERIFY_BLOB as an option, do you?

So I do not care too strongly about this feature, if it were to be added, I think you would need to separate error messages and type verification should not be lax, I would think.