git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] verify-tag: allow to verify signed blob objects

From
Jacob Keller <jacob.keller@gmail.com>
Date
Jun 15, 2016, 21:41 UTC
Message-ID
<CA+P7+xqV8t1cJeAtNQeWaFbKC5DrhpPoUJ9GWAuPrO=GZpKaiQ@mail.gmail.com>
In-Reply-To
<xmqqziqm5k7j.fsf@gitster.mtv.corp.google.com>
On Wed, Jun 15, 2016 at 12:24 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 25 quoted lines
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>
>>> Or even
>>>
>>>      if ((flags & GPG_VERIFY_BLOB) && (type != OBJ_BLOB))
>>>                      "you told me to check blob but didn't give me one";
>>>      } else if (type != OBJ_TAG)
>>>              "you didn't give me a tag";
>>>
>>
>> I just tried to stay as close to the original as possible, but I don't
>> care either way. Your latter version is more strict and would require a
>> slight documentation change, but would be fine, too.
>
> Actually, the message you reused is not reusable for this new mode.
> I guess starting from more strict (which makes sense, as you do not
> want to silently say "Yeah, the blob verifies OK" when the user
> tells you "I want you to verify this blob, and here it is" and hands
> you a tag.  If that were an acceptable behaviour, you do not even
> need VERIFY_BLOB as an option, do you?
>
> So I do not care too strongly about this feature, if it were to be
> added, I think you would need to separate error messages and type
> verification should not be lax, I would think.
>

I agree that Junio's suggestion is (a) both easier to read and (b) more clear to the end user, and thus preferable.

Thanks, Jake

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “verify-tag: allow to verify signed blob objects”
  1. verify-tag: allow to verify signed blob objectsMichael J Gruber, Jun 15, 2016
  2. Junio C HamanoJun 15, 2016
  3. Michael J GruberJun 15, 2016
  4. Junio C HamanoJun 15, 2016
  5. Jacob KellerJun 15, 2016
  6. Junio C HamanoJun 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.