Re: [PATCH v14 00/21] index-helper/watchman
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 6, 2016, 18:11 UTC
- Message-ID
- <xmqqzipuskkj.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1467532693-20017-1-git-send-email-novalis@novalis.org>
David Turner <novalis@novalis.org> writes:
Show 5 quoted lines
> This addresses comments on v13: > removed unnecessary no_mmap ifdef > add an ifdef in unix-socket > OS X fix for select() > test improvement
Thanks. It seems that what used to be 809fd05a (read-cache.c: fix constness of verify_hdr(), 2016-06-26) is no longer included in the series, even though the tightening of the constness seems to still be OK (i.e. verify_hdr() function takes the parameter hdr and only uses it read-only). Do you want me to keep it, or (more likely) did I miss some discussion that reached the concensus that we do not want it?