git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v14 15/21] index-helper: kill mode

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 6, 2016, 08:20 UTC
Message-ID
<alpine.DEB.2.20.1607061016330.6426@virtualbox>
In-Reply-To
<1467532693-20017-16-git-send-email-novalis@novalis.org>
Hi Dave,
On Sun, 3 Jul 2016, David Turner wrote:
Show 10 quoted lines
> @@ -357,10 +359,29 @@ static const char * const usage_text[] = {
>  	NULL
>  };
>  
> +static void request_kill(void)
> +{
> +	int fd = unix_stream_connect(git_path("index-helper.sock"));
> +
> +	if (fd >= 0) {
> +		write_in_full(fd, "die", 4);

I believe that this is incorrect. When I interrupt t7900 after the 3rd test case, it says

	fatal: protocol error: bad line length character: die

twice, suggesting that this write_in_full() actually needs to be a packet_write(fd, "die") instead, seeing as loop() uses the packet_read() call to read the messages.

BTW I am in the middle of trying to abstract out a "simple server" that will allow me to back the inter-process communication by a pure Windows solution (named pipes) instead of the Unix sockets. It turns out to be much more difficult than I hoped: the code is really relying on Unix sockets currently.

Will keep you posted, Dscho

Previous: David TurnerNext: Duy Nguyen
Message 15 of 30 in “index-helper/watchman”
  1. 00/21 index-helper/watchmanDavid Turner, Jul 3, 2016
  2. 03/21 unix-socket.c: add stub implementation when unix sockets are not supportedDavid Turner, Jul 3, 2016
  3. 05/21 index-helper: add --strictDavid Turner, Jul 3, 2016
  4. 06/21 daemonize(): set a flag before exiting the main processDavid Turner, Jul 3, 2016
  5. 02/21 pkt-line: add gentle version of packet_writeDavid Turner, Jul 3, 2016
  6. 01/21 read-cache: allow to keep mmap'd memory after readingDavid Turner, Jul 3, 2016
  7. 04/21 index-helper: new daemon for caching index and related stuffDavid Turner, Jul 3, 2016
  8. 16/21 index-helper: don't run if already runningDavid Turner, Jul 3, 2016
  9. 17/21 index-helper: autorun modeDavid Turner, Jul 3, 2016
  10. 18/21 index-helper: optionally automatically runDavid Turner, Jul 3, 2016
  11. 19/21 trace: measure where the time is spent in the index-heavy operationsDavid Turner, Jul 3, 2016
  12. 07/21 index-helper: add --detachDavid Turner, Jul 3, 2016
  13. 13/21 unpack-trees: preserve index extensionsDavid Turner, Jul 3, 2016
  14. 15/21 index-helper: kill modeDavid Turner, Jul 3, 2016
  15. Johannes SchindelinJul 6, 2016
  16. Duy NguyenJul 6, 2016
  17. 12/21 update-index: enable/disable watchman supportDavid Turner, Jul 3, 2016
  18. 14/21 watchman: add a config option to enable the extensionDavid Turner, Jul 3, 2016
  19. 09/21 read-cache: add watchman 'WAMA' extensionDavid Turner, Jul 3, 2016
  20. 11/21 index-helper: use watchman to avoid refreshing index with lstat()David Turner, Jul 3, 2016
  21. 10/21 watchman: support watchman to reduce index refresh costDavid Turner, Jul 3, 2016
  22. 08/21 index-helper: log warningsDavid Turner, Jul 3, 2016
  23. Johannes SchindelinJul 3, 2016
  24. Johannes SchindelinJul 4, 2016
  25. Junio C HamanoJul 6, 2016
  26. Duy NguyenJul 12, 2016
  27. David TurnerJul 13, 2016
  28. Duy NguyenJul 14, 2016
  29. Duy NguyenJul 14, 2016
  30. Ben PeartJul 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.