Re: [PATCH 1/1 v2] pager: move pager-specific setup into the build

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 3, 2016, 21:15 UTC
Message-ID: <xmqqziot7dv6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160803210821.GA17510@whir>

Eric Wong <e@80x24.org> writes:

Show 8 quoted lines

> Junio C Hamano <gitster@pobox.com> wrote:
>> All bugs are from my original, I think.  Here is a proposed squash.
>
> Thanks, I'll take the git-sh-setup changes.
>
> I actually just rewrote setup_pager_env using split_cmdline and
> eliminated all the scary (to me) pointer arithmetic and avoided
> strbuf, too.

I actually do not have much faith in split_cmdline() in that I cannot quite read and follow the flow of the logic in its implementation, but it already is used widely so it must be OK, so I am fine if you use it as a black-box to make this code simpler ;-)

I'll drop the squash then and replace it with your version when it comes.

Thanks.