Re: [PATCH 2/2] pager: implement core.pagerEnv in config

From: Jeff King <peff@peff.net>
Date: Aug 1, 2016, 17:28 UTC
Message-ID: <20160801172851.k2vtqwik2hkblr4e@sigill.intra.peff.net>
In-Reply-To: <20160801010557.22191-3-e@80x24.org>

On Mon, Aug 01, 2016 at 01:05:57AM +0000, Eric Wong wrote:

Show 5 quoted lines

> This allows overriding the build-time PAGER_ENV variable
> at run-time.
> 
> Inspired by part 1 of an idea from Kyle J. McKay at:
> https://public-inbox.org/git/62DB6DEF-8B39-4481-BA06-245BF45233E5@gmail.com/

This commit message is missing the "why" (I tried to get it from the referenced email, but I am still confused).

What does this buy you over:

  GIT_PAGER='less -whatever-options-you-like'

? Sure, you have to say "less" there and not just "if we happen to be using less, use these options with it". But that distinction is important for a build-time default, not for a run-time one. And by pointing people to GIT_PAGER, they can do a lot _more_ than they can with PAGER_ENV, including the full power of the shell (brian gave an example of "par | less" earlier; I use "diff-highlight | less").

-Peff