git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkout: do not mention detach advice for explicit --detach option

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 11, 2016, 18:09 UTC
Message-ID
<xmqqzioj18kg.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAGZ79kb+PvU5yKfr9D0j13JWeo1mqcW=CWvVD88UrEeg1WBTpQ@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
Show 10 quoted lines
> On Wed, Aug 10, 2016 at 10:32 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Stefan Beller wrote:
>>
>>> When a user asked for a detached HEAD specifically with `--detach`,
>>> we do not need to give advice on what a detached HEAD state entails as
>>> we can assume they know what they're getting into as they asked for it.
>>
>> Example? Tests?
>
> There are no tests for the advice things IIUC.

There seem to already be tests that explicitly sets advice.* to true like in t7201 and t7512, but even if there weren't any existing ones, it would be appropriate to make sure that an explicit --detach does not trigger the advice, even when advice.detachedHEAD left unconfigured (or set to true), given that doing so is the whole purpose of this patch, I would think.

Previous: Stefan Beller
Message 5 of 5 in “checkout: do not mention detach advice for explicit --detach option”
  1. checkout: do not mention detach advice for explicit --detach optionStefan Beller, Aug 10, 2016
  2. Junio C HamanoAug 10, 2016
  3. Jonathan NiederAug 10, 2016
  4. Stefan BellerAug 10, 2016
  5. Junio C HamanoAug 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.