From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 11 Aug 2016 18:09:35 GMT
Subject: Re: [PATCH] checkout: do not mention detach advice for explicit --detach option
Message-ID: <xmqqzioj18kg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kb+PvU5yKfr9D0j13JWeo1mqcW=CWvVD88UrEeg1WBTpQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> On Wed, Aug 10, 2016 at 10:32 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Stefan Beller wrote:
>>
>>> When a user asked for a detached HEAD specifically with `--detach`,
>>> we do not need to give advice on what a detached HEAD state entails as
>>> we can assume they know what they're getting into as they asked for it.
>>
>> Example? Tests?
>
> There are no tests for the advice things IIUC.

There seem to already be tests that explicitly sets advice.* to true
like in t7201 and t7512, but even if there weren't any existing
ones, it would be appropriate to make sure that an explicit --detach
does not trigger the advice, even when advice.detachedHEAD left
unconfigured (or set to true), given that doing so is the whole
purpose of this patch, I would think.