Re: [PATCH 1/3] diff-highlight: add some tests.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 16, 2016, 20:48 UTC
Message-ID: <xmqqziocbftd.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <A2BCF055-D3FD-4EFC-88FF-A3916BCF8FDF@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 17 quoted lines

>> On 30 Jul 2016, at 17:11, Brian Henderson <henderson.bj@gmail.com> wrote:
>> 
>> ---
>> contrib/diff-highlight/Makefile                  |  5 ++
>> contrib/diff-highlight/t/Makefile                | 19 +++++++
>> contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++++++++++++++++++++++
>> contrib/diff-highlight/t/test-diff-highlight.sh  | 69 ++++++++++++++++++++++++
>> 4 files changed, 156 insertions(+)
>> create mode 100644 contrib/diff-highlight/Makefile
>> create mode 100644 contrib/diff-highlight/t/Makefile
>> create mode 100644 contrib/diff-highlight/t/t9400-diff-highlight.sh
>> create mode 100644 contrib/diff-highlight/t/test-diff-highlight.sh
>> 
>> diff --git a/contrib/diff-highlight/Makefile b/contrib/diff-highlight/Makefile
>
> Would it make sense to add the contrib tests to the Travis-CI build, too?
> https://travis-ci.org/git/git/branches

The more the merrier ;-)? I do not think of a downside, especially if you are adding it as a separate thing that comes after the main test, or for even better isolation, an entirely separate job.

By the way, how flaky are existing tests? Are people actively following breakage reports?