Re: [PATCH 1/3] diff-highlight: add some tests.

From: Lars Schneider <larsxschneider@gmail.com>
Date: Aug 24, 2016, 09:38 UTC
Message-ID: <C1987BCB-8FE1-43AD-B8A0-06F58A4E73F0@gmail.com>
In-Reply-To: <xmqqziocbftd.fsf@gitster.mtv.corp.google.com>

Show 25 quoted lines

> On 16 Aug 2016, at 22:48, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>>> On 30 Jul 2016, at 17:11, Brian Henderson <henderson.bj@gmail.com> wrote:
>>> 
>>> ---
>>> contrib/diff-highlight/Makefile                  |  5 ++
>>> contrib/diff-highlight/t/Makefile                | 19 +++++++
>>> contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++++++++++++++++++++++
>>> contrib/diff-highlight/t/test-diff-highlight.sh  | 69 ++++++++++++++++++++++++
>>> 4 files changed, 156 insertions(+)
>>> create mode 100644 contrib/diff-highlight/Makefile
>>> create mode 100644 contrib/diff-highlight/t/Makefile
>>> create mode 100644 contrib/diff-highlight/t/t9400-diff-highlight.sh
>>> create mode 100644 contrib/diff-highlight/t/test-diff-highlight.sh
>>> 
>>> diff --git a/contrib/diff-highlight/Makefile b/contrib/diff-highlight/Makefile
>> 
>> Would it make sense to add the contrib tests to the Travis-CI build, too?
>> https://travis-ci.org/git/git/branches
> 
> The more the merrier ;-)?  I do not think of a downside, especially
> if you are adding it as a separate thing that comes after the main
> test, or for even better isolation, an entirely separate job.

OK, if I will post a patch (might take a while).

> By the way, how flaky are existing tests?  Are people actively
> following breakage reports?

Good question - I was curious about that, too. That's why I made a little website (only tested on Chrome, requires JS):

https://larsxschneider.github.io/git-ci-stats/

There you can see all builds for all branches including their failure reason. In general I would say flakiness is no issue anymore.

I don't know who else is looking at the breakage reports but I do. That's the reason for my "next" breakage reports in the past:

http://public-inbox.org/git/A6131C47-3230-4EC4-B3F6-B2507C937A22@gmail.com/ http://public-inbox.org/git/4877318E-3CBF-4C87-B24D-AAE35C427D66@gmail.com/ http://public-inbox.org/git/FB76544F-16F7-45CA-9649-FD62EE44B0DE@gmail.com/ ...

Cheers, Lars