Re: [PATCHv3] submodule--helper: normalize funny urls

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2016, 19:26 UTC
Message-ID: <xmqqzilyg6tk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kY4u-k8v3g5Jmod4acwJ81AnJYeYMQZ2tarx6UMGj8Xew@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> Do we actually want to fix git-clone as well?

If I understand correctly, the point of this fix is to make it not to matter whether the original URL the end user gives or recorded as the remote by "git clone" in the repository is any one of:

	$any_leading_part/path/to/dir
	$any_leading_part/path/to/dir/
	$any_leading_part/path/to/dir/.

So I do not think there is anything to "fix", as long as "git clone" that is given any one of the above three records any one of the above three as the result. It _may_ be desirable if the result is identical what was given as input, but I do not offhand think that is required.

> I tried and then I see breakage in 5603-clone-dirname
> as ssh://host seems to be an invalid url; it has to end with a slash?

That is a separate issue, isn't it? We shouldn't be touching the leading "<scheme>://<host>/" part, I would think.

For example, a URL "../another" relative to "ssh://host/path" may be "ssh://host/another", but shouldn't it be an error to take "../../outside" relative to "ssh://host/path"?