Re: [PATCHv3] submodule--helper: normalize funny urls

From: Stefan Beller <sbeller@google.com>
Date: Oct 20, 2016, 19:15 UTC
Message-ID: <CAGZ79kY4u-k8v3g5Jmod4acwJ81AnJYeYMQZ2tarx6UMGj8Xew@mail.gmail.com>
In-Reply-To: <xmqqwph5m6th.fsf@gitster.mtv.corp.google.com>

On Tue, Oct 18, 2016 at 7:05 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 20 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>>> I am not sure.  Certainly we would want to make sure that the normal
>>> case (i.e. no funny trailing junk) to work correctly, but we do want
>>> to protect the fix from future breakage as well, no?
>>
>> Exactly. So not intermediate "root" that we clone from, but adapting the
>> relative URLs. Maybe half the broken tests can switch to 'root' and the others
>> go with the current behavior of cloning . to super.
>>>
>>> Perhaps we can do a preliminary step to update tests to primarily
>>> check the cases that do not involve URL with trailing "/." by either
>>> doing that double clone, or more preferrably, clone from "$(pwd)"
>>> and adjust the incorrect submodule reference that have been relying
>>> on the buggy behaviour.  With that "root" trick, the test would pass
>>> with or without the fix under discussion, right?
>>
>> I assume so, (not tested).
>
> OK.  Thanks for sticking with it.

Do we actually want to fix git-clone as well? I tried and then I see breakage in 5603-clone-dirname as ssh://host seems to be an invalid url; it has to end with a slash?

If we were to fix clone as well, then we'd still have a lot of possible stale data (ending in /.) out there, so maybe we want to not fix clone for now and only fix it when computing the submodule url.

So I'll first fix up the test suite to not rely on buggy behavior and then send this patch with no change in tests? That sounds strange to me as it hides away the cause.