Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2017, 14:31 UTC
Message-ID: <xmqqzij0uwxp.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq4m18wbo5.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> In any case, it does not break things, and it helps Cygwin, so: ACK
>>
>> Ciao,
>> Dscho
>>
>> P.S.: I pushed this to Git for Windows' `master`, too:
>> https://github.com/git-for-windows/git/commit/f05a26948b
>
> Hmm, I peeked it hoping that you corrected the log message along the
> lines of your <alpine.DEB.2.20.1701081953330.3469@virtualbox>, but
> it appears that what you queued does not have any extra mention of
> cygwin or specifics of the buildchain on top of what Steven posted?

Ah, false alarm. It does have s/Windows/Cygwin/; I trust your judgement that that change makes the context clear enough for those involved in Git for Windows, msysGit and Cygwin port.

Will queue it together with the other one from Steven.

Thanks.