Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 9, 2017, 03:07 UTC
- Message-ID
- <xmqqy3ylx75g.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1701081953330.3469@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 14 quoted lines
> Hi Steven, > > On Sun, 8 Jan 2017, Steven Penny wrote: > >> On Sun, Jan 8, 2017 at 5:54 AM, Johannes Schindelin wrote: >> > I am curious: how do you build Git? I ask because I build Git on Windows >> > many times a day, and I did not encounter any link problems. >> >> My end goal is to build static native Windows Git via Cygwin and the >> mingw64-x86_64-gcc-core package. > > That is certainly a worthy goal, and I would highly recommend to mention > that particular cross-compiling setup in the commit message. It's not like > this is the easiest way to build native Git on Windows...
In addition to the patch being explained well, I also care that it does not break existing builds. I do not think it is the case for you, and I do think the patch does the right thing, but just double checking to see if you have objections to the change itself.
Thanks.