Re: [PATCH] git-bisect: allow running in a working tree subdirectory

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2017, 23:22 UTC
Message-ID: <xmqqziid1k51.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <96afaa1d-31d7-0b7e-d2b3-77a455158638@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 28 quoted lines

> Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> It looks like it can do it.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>>  git-bisect.sh | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/git-bisect.sh b/git-bisect.sh
>> index ae3cb013e..b0bd604d4 100755
>> --- a/git-bisect.sh
>> +++ b/git-bisect.sh
>> @@ -1,5 +1,6 @@
>>  #!/bin/sh
>>
>> +SUBDIRECTORY_OK=Yes
>>  USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
>>  LONG_USAGE='git bisect help
>>  	print this long help message.
>>
>
> Does it also work to drive git bisect from a subdirectory and pass a
> file name (or pathspec) that is relative to that subdirectory rather
> than relative to the root of the worktree? Can `git bisect good` or
> `git bisect bad` of later bisection steps be invoked from different
> subdirectories or the root?

I think the answers are no and no. Entries in BISECT_NAMES and BISECT_LOG are not getting any prefix.