Re: [PATCH] git-bisect: allow running in a working tree subdirectory

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2017, 19:34 UTC
Message-ID: <xmqqk29h4nv4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZkxnoKCyk9teQnEPjsnS7iEorZALY4dXE8Fy78ifur7g@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 9 quoted lines

> + Duy, main author of the worktree feature.
>
> On Thu, Jan 26, 2017 at 10:30 AM,  <marcandre.lureau@redhat.com> wrote:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> It looks like it can do it.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---

I do not think the OP meant by "a working tree subdirectory" using the command in a secondary worktree. SUBDIRECTORY_OK is about "can the command be started in a subdirectory (as opposed to requiring to be run only at the toplevel)?"

I am slightly negative on this change, though. The subdirectory you are sitting in when you start your bisection may disappear and reappear as you dig the history, and I do not think the code makes anything special to prevent the disappearing current directory from getting in the way of bisection process.

Show 17 quoted lines

>>  git-bisect.sh | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/git-bisect.sh b/git-bisect.sh
>> index ae3cb013e..b0bd604d4 100755
>> --- a/git-bisect.sh
>> +++ b/git-bisect.sh
>> @@ -1,5 +1,6 @@
>>  #!/bin/sh
>>
>> +SUBDIRECTORY_OK=Yes
>>  USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
>>  LONG_USAGE='git bisect help
>>         print this long help message.
>> --
>> 2.11.0.295.gd7dffce1c.dirty
>>