Re: [PATCH 2/3] parse_config_key: allow matching single-level config

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 24, 2017, 21:20 UTC
Message-ID: <xmqqzihbz3nz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170224210802.rpr5vdpqhsp3pt5v@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> The parse_config_key() function was introduced to make it
> easier to match "section.subsection.key" variables. It also
> handles the simpler "section.key", and the caller is
> responsible for distinguishing the two from its
> out-parameters.
>
> Most callers who _only_ want "section.key" would just use a
> strcmp(var, "section.key"), since there is no parsing
> required. However, they may still use parse_config_key() if
> their "section" variable isn't a constant (an example of
> this is in parse_hide_refs_config).

Perhaps "only" at the end of the title?

After grepping for call sites of this function, I think we can simplify quite a few instances of:

	if (parse_config_key(...) || !name)
		return ...;