[PATCH] refs: parse_hide_refs_config to use parse_config_key
- From
Stefan Beller <sbeller@google.com>
- Date
- Feb 24, 2017, 20:43 UTC
- Message-ID
- <20170224204335.10652-1-sbeller@google.com>
- In-Reply-To
- <20170224203940.hbmfsouw5k67l3h3@sigill.intra.peff.net>
parse_config_key was introduced in 1b86bbb0ade (config: add helper function for parsing key names, 2013-01-22), the NEEDSWORK that is removed in this patch was introduced at daebaa7813 (upload/receive-pack: allow hiding ref hierarchies, 2013-01-18), which is only a couple days apart, so presumably the code replaced in this patch was only introduced due to not wanting to wait on the proper helper function being available.
Make the condition easier to read by using parse_config_key.
Signed-off-by: Stefan Beller <sbeller@google.com> --- refs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/refs.c b/refs.c index cd36b64ed9..21bc8c9101 100644 --- a/refs.c +++ b/refs.c @@ -1034,10 +1034,11 @@ static struct string_list *hide_refs; int parse_hide_refs_config(const char *var, const char *value, const char *section) { + const char *subsection, *key; + int subsection_len; if (!strcmp("transfer.hiderefs", var) || - /* NEEDSWORK: use parse_config_key() once both are merged */ - (starts_with(var, section) && var[strlen(section)] == '.' && - !strcmp(var + strlen(section), ".hiderefs"))) { + (!parse_config_key(var, section, &subsection, &subsection_len, &key) + && !subsection && !strcmp(key, "hiderefs"))) { char *ref; int len;
-- 2.12.0.rc1.16.ge4278d41a0.dirty