git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] Some add-on patches on top of dj/runtime-prefix

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 24, 2018, 01:44 UTC
Message-ID
<xmqqzi1t74zo.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<cover.1524309209.git.johannes.schindelin@gmx.de>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
Show 27 quoted lines
> We carried a slightly different version of the git_setup_gettext() patch
> (which took care of releasing the buffer allocated by system_path()),
> and we carry two more patches that touch the same area, so now that
> dj/runtime-prefix hit `next`, it seems a good time to contribute those,
> too.
>
> Changes since v1:
>
> - clarified in v1 why we cannot simply force users to recompile with NO_GETTEXT
>   instead.
>
>
> Johannes Schindelin (2):
>   gettext: avoid initialization if the locale dir is not present
>   git_setup_gettext: plug memory leak
>
> Philip Oakley (1):
>   Avoid multiple PREFIX definitions
>
>  Makefile   |  2 +-
>  exec-cmd.c |  4 ++--
>  gettext.c  | 10 +++++++++-
>  sideband.c | 10 +++++-----
>  4 files changed, 17 insertions(+), 9 deletions(-)
>
>
> base-commit: b46fe60e1d7235603a29499822493bd3791195da

Basing your work on the tip of 'next' is good for discussion, but not readily usable for final application. Let me see if I can untangle the dependents to come up with a reasonable base.

The changes themselves looked reasonable.  Thanks.
Previous: Johannes SchindelinNext: Junio C Hamano
Message 16 of 21 in “Some add-on patches on top of dj/runtime-prefix”
  1. 0/3 Some add-on patches on top of dj/runtime-prefixJohannes Schindelin, Apr 20, 2018
  2. 1/3 gettext: avoid initialization if the locale dir is not presentJohannes Schindelin, Apr 20, 2018
  3. Ævar Arnfjörð BjarmasonApr 20, 2018
  4. Martin ÅgrenApr 20, 2018
  5. Ævar Arnfjörð BjarmasonApr 20, 2018
  6. Johannes SchindelinApr 20, 2018
  7. Ævar Arnfjörð BjarmasonApr 21, 2018
  8. Johannes SchindelinApr 21, 2018
  9. 2/3 git_setup_gettext: plug memory leakJohannes Schindelin, Apr 20, 2018
  10. 3/3 Avoid multiple PREFIX definitionsJohannes Schindelin, Apr 20, 2018
  11. Philip OakleyApr 22, 2018
  12. 0/3 Some add-on patches on top of dj/runtime-prefixJohannes Schindelin, Apr 21, 2018
  13. 1/3 gettext: avoid initialization if the locale dir is not presentJohannes Schindelin, Apr 21, 2018
  14. 2/3 git_setup_gettext: plug memory leakJohannes Schindelin, Apr 21, 2018
  15. 3/3 Avoid multiple PREFIX definitionsJohannes Schindelin, Apr 21, 2018
  16. Junio C HamanoApr 24, 2018
  17. Junio C HamanoApr 24, 2018
  18. Junio C HamanoApr 24, 2018
  19. Johannes SchindelinApr 24, 2018
  20. Junio C HamanoApr 25, 2018
  21. Johannes SchindelinApr 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.