Re: [PATCH v6 1/1] http: add support selecting http version
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 9, 2018, 02:56 UTC
- Message-ID
- <xmqqzhuj5574.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <93fda67198441c159bfcf1dfa467ad76f3ecba76.1541660405.git.gitgitgadget@gmail.com>
"Force Charlie via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 19 quoted lines
> +#if LIBCURL_VERSION_NUM >=0x072f00
> +static int get_curl_http_version_opt(const char *version_string, long *opt)
> +{
> + int i;
> + static struct {
> + const char *name;
> + long opt_token;
> + } choice[] = {
> + { "HTTP/1.1", CURL_HTTP_VERSION_1_1 },
> + { "HTTP/2", CURL_HTTP_VERSION_2 }
> + };
> +
> + for (i = 0; i < ARRAY_SIZE(choice); i++) {
> + if (!strcmp(version_string, choice[i].name)) {
> + *opt = choice[i].opt_token;
> + return 0;
> + }
> + }
> +I wonder if we need to give a warning here about an unknown and ignored value, by calling something like
warning("unknown value given to http.version: '%s'", version_string);here. We should not trigger noisy warning while reading the configuration file looking for other variables unrelated to http.version but this codepath is followed only when we know we need to find out what value the variable is set to, so it probably is a good thing to do.
Thoughts?