Re: [PATCH v3 0/4] http: add support selecting http version
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 8, 2018, 06:14 UTC
- Message-ID
- <xmqqy3a46qpt.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <pull.69.v3.git.gitgitgadget@gmail.com>
"Force.Charlie-I via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 14 quoted lines
> Normally, git doesn't need to set curl to select the HTTP version, it works > fine without HTTP/2. Adding HTTP/2 support is a icing on the cake. > > This patch support force enable HTTP/2 or HTTP/1.1. > > example: > > GIT_CURL_VERBOSE=1 git2 -c http.version=HTTP/2 ls-remote https://bitbucket.org/aquariusjay/deeplab-public-ver2.git > > Force Charlie (4): > http: add support selecting http version > support force use http 1.1 > fix curl version to support CURL_HTTP_VERSION_2TLS > http: change http.version value type
When somebody reads over these four patches as a first-time reader, I think s/he notices a couple of things:
- In the proposed log messages, there is no explanation on the reason why we are doing these changes.
- Each of the steps n/4 (n > 1) looks more like "oops, it was a mistake that we did not do this in earlier patch, and here is to correct that".
- There is no test or documentation.
I suspect that a single patch that updates http.c, Documentation/ and t/ at the same time should be sufficient for a change of this size.
Thanks.
Show 15 quoted lines
> http.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > > base-commit: 8858448bb49332d353febc078ce4a3abcc962efe > Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-69%2Ffcharlie%2Fmaster-v3 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-69/fcharlie/master-v3 > Pull-Request: https://github.com/gitgitgadget/git/pull/69 > > Range-diff vs v2: > > 1: 4f5a935c43 = 1: 4f5a935c43 http: add support selecting http version > 2: 06e9685d2b = 2: 06e9685d2b support force use http 1.1 > 3: eee67d8356 = 3: eee67d8356 fix curl version to support CURL_HTTP_VERSION_2TLS > -: ---------- > 4: ef975b6093 http: change http.version value type