Re: [PATCH] revision.c: fix sparse warnings (sparse algorithm)

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 15, 2019, 18:29 UTC
Message-ID: <xmqqzhs1srki.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <a0ace9a0-65f9-ad2e-26f8-b46e3ef0153e@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 23 quoted lines

> On 1/13/2019 3:55 PM, Ramsay Jones wrote:
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Derrick,
>>
>> If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
>> you please squash this into the relevant patch [commit 9949aaeef4
>> ("revision: implement sparse algorithm", 2018-12-14)].
>>
>> This commit caused both 'sparse' and my 'static-check.pl' script to
>> complain about the visibility of the 'map_flags' variable (it is a
>> file local variable), so one solution would be to mark it 'static'.
>> However, it is simply not being used, so ...
>>
>> Thanks!
>>
>> ATB,
>> Ramsay Jones
>
> Thanks, Ramsay! I'm rerolling the series today, so I will make this change.
>
> -Stolee

Thanks, both.