Re: [PATCH] revision.c: fix sparse warnings (sparse algorithm)

From: Derrick Stolee <stolee@gmail.com>
Date: Jan 15, 2019, 14:42 UTC
Message-ID: <a0ace9a0-65f9-ad2e-26f8-b46e3ef0153e@gmail.com>
In-Reply-To: <0f69cce6-a0a0-8972-93dd-5c1aa428f508@ramsayjones.plus.com>

On 1/13/2019 3:55 PM, Ramsay Jones wrote:

Show 18 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
> you please squash this into the relevant patch [commit 9949aaeef4
> ("revision: implement sparse algorithm", 2018-12-14)].
>
> This commit caused both 'sparse' and my 'static-check.pl' script to
> complain about the visibility of the 'map_flags' variable (it is a
> file local variable), so one solution would be to mark it 'static'.
> However, it is simply not being used, so ...
>
> Thanks!
>
> ATB,
> Ramsay Jones

Thanks, Ramsay! I'm rerolling the series today, so I will make this change.

-Stolee