git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-list: allow cached objects in existence check

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 5, 2019, 13:33 UTC
Message-ID
<xmqqzhq9tpie.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190304211749.GA3020@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
>> Or teach git-blame to have its own pretend mechanism, and remove the
>> pretend mechanism from sha1-file.c.
>
> I think that would be ideal, but I'm not sure if it's feasible due to
> the layering of the various modules.

Sorry, but I do not get why we want command-line specific pretend mechanism. When one part of the system wants to behave as if object X exists, doesn't that part want other parts of the system to share that same world view to be consistent?

I am mostly reacting to "would be _ideal_"; if it were "if we have per-system ad-hoc pretend mechanism, things like this and that would become easier to implement, even though that is an ugly hack", I may agree when I see examples of things that get easier, though.

Previous: Jeff KingNext: Jeff King
Message 4 of 6 in “rev-list: allow cached objects in existence check”
  1. rev-list: allow cached objects in existence checkJeff King, Mar 4, 2019
  2. Jonathan TanMar 4, 2019
  3. Jeff KingMar 4, 2019
  4. Junio C HamanoMar 5, 2019
  5. Jeff KingMar 5, 2019
  6. Junio C HamanoMar 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.