From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 05 Mar 2019 13:33:13 GMT
Subject: Re: [PATCH] rev-list: allow cached objects in existence check
Message-ID: <xmqqzhq9tpie.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190304211749.GA3020@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> Or teach git-blame to have its own pretend mechanism, and remove the
>> pretend mechanism from sha1-file.c.
>
> I think that would be ideal, but I'm not sure if it's feasible due to
> the layering of the various modules.

Sorry, but I do not get why we want command-line specific pretend
mechanism.  When one part of the system wants to behave as if object
X exists, doesn't that part want other parts of the system to share
that same world view to be consistent?

I am mostly reacting to "would be _ideal_"; if it were "if we have
per-system ad-hoc pretend mechanism, things like this and that would
become easier to implement, even though that is an ugly hack", I may
agree when I see examples of things that get easier, though.