Re: ab/send-email-transferencoding-fix, was Re: What's cooking in git.git (May 2019, #04; Tue, 28)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 29, 2019, 19:54 UTC
- Message-ID
- <xmqqzhn5xci3.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1905292009030.44@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 5 quoted lines
>> Yeah, I recall that one from previous week. Let's queue it on top >> (and find the right place tos quash it in). > > Sorry, I was unclear. The commit to amend is the tip one: "send-email: fix > regression in sendemail.identity parsing".
No need to be sorry---I found it out after applying and for a single liner, it is trivial to see which commit it needs to be squashed into ;)
FWIW, I learned to try to respond as early as possible to help unblock other people, and as a consequence, my response may come before I know exactly what the task is, or when I can get to the task that I promise in my response. When I wrote the above, I didn't exactly recall how many tests your follow-up patch I saw earlier (or the one you sent this time) was adding prerequisites, and I didn't yet know how involved it would be to find where it applies when I wrote my response.