Re: What's cooking in git.git (May 2019, #04; Tue, 28)

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2019, 16:53 UTC
Message-ID: <xmqqlfypyzfr.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190528222604.GA14921@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 24 quoted lines

> On Tue, May 28, 2019 at 03:08:31PM -0700, Junio C Hamano wrote:
>
>> Quite a few new topics, most of which are fixes with different
>> urgency, have been picked up.  Perhaps we'd need an extra -rc for
>> this cycle to squash existing regression at the tip of 'master'.
>> At this point, the criteria for merging to 'master' is *NOT* "This
>> is an obviously correct fix", but is "This is an obviously correct
>> fix for a breakage we introduced during this cycle".
>>
>> [...]
>>
>> * ds/object-info-for-prefetch-fix (2019-05-28) 1 commit
>>  - sha1-file: split OBJECT_INFO_FOR_PREFETCH
>> 
>>  Code cleanup.
>> 
>>  Will merge to 'next'.
>
> I think this one is actually a bug-fix (we are refusing to prefetch for
> "QUICK" calls even though was not the intent), and it is new in this
> release.
>
> I'm not sure of the user-visible impacts, though. There are a lot of
> QUICK calls, and I'm not sure for which ones it is important to fetch.

Hmph. I took it as primarily futureproofing, as I didn't find a way to trigger bad behaviour from within the current codebase.