git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] clean: optimize and document cases where we recurse into subdirectories

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2020, 00:28 UTC
Message-ID
<xmqqzh97zu5k.fsf@gitster.c.googlers.com>
In-Reply-To
<b4cb448e8d76ae16f6fa38a773244bb4a8499938.1591858774.git.gitgitgadget@gmail.com>
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> ...
> However, in clean's case we don't need to recurse into ignored
> directories; that is just a waste of time.
Nice.
Show 5 quoted lines
> Rather than relying on other bugs in fill_directory()'s former
> logic to provide the behavior of skipping ignored directories, make use
> of the DIR_SHOW_IGNORED_TOO_MODE_MATCHING value specifically added in
> commit eec0f7f2b7 ("status: add option to show ignored files
> differently", 2017-10-30) for this purpose.
Thanks.
Previous: Elijah Newren via GitGitGadgetNext: Brian Malehorn
Message 6 of 7 in “Clean cleanups”
  1. 0/4 Clean cleanupsElijah Newren via GitGitGadget, Jun 11, 2020
  2. 1/4 dir: fix a few confusing commentsElijah Newren via GitGitGadget, Jun 11, 2020
  3. 2/4 dir, clean: avoid disallowed behaviorElijah Newren via GitGitGadget, Jun 11, 2020
  4. 3/4 clean: consolidate handling of ignored parametersElijah Newren via GitGitGadget, Jun 11, 2020
  5. 4/4 clean: optimize and document cases where we recurse into subdirectoriesElijah Newren via GitGitGadget, Jun 11, 2020
  6. Junio C HamanoJun 13, 2020
  7. Brian MalehornJun 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.