Re: [PATCH 4/4] clean: optimize and document cases where we recurse into subdirectories
- From
Brian Malehorn <bmalehorn@gmail.com>
- Date
- Jun 18, 2020, 06:19 UTC
- Message-ID
- <CAJB88a0PkHmZTVQSi2tQZ7b2Adk46k0qEU4Xz8W+bYuHAeunuw@mail.gmail.com>
- In-Reply-To
- <xmqqzh97zu5k.fsf@gitster.c.googlers.com>
Catching up on this - thanks Elijah for jumping on this bug and fixing it immediately. I'll let you know if I see similar bugs in the future.
Thanks, Brian
On Fri, Jun 12, 2020 at 5:28 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > ...
> > However, in clean's case we don't need to recurse into ignored
> > directories; that is just a waste of time.
>
> Nice.
>
> > Rather than relying on other bugs in fill_directory()'s former
> > logic to provide the behavior of skipping ignored directories, make use
> > of the DIR_SHOW_IGNORED_TOO_MODE_MATCHING value specifically added in
> > commit eec0f7f2b7 ("status: add option to show ignored files
> > differently", 2017-10-30) for this purpose.
>
> Thanks.
>