Re: [RESEND PATCH] bisect: use oid_to_hex_r() instead of memcpy()+oid_to_hex()

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2020, 20:03 UTC
Message-ID: <xmqqzh7crf29.fsf@gitster.c.googlers.com>
In-Reply-To: <632682d5-e343-c069-f4b4-0451072d54d2@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 8 quoted lines

> Write the hexadecimal object ID directly into the destination buffer
> using oid_to_hex_r() instead of writing it into a static buffer first
> using oid_to_hex() and then copying it from there using memcpy().
> This is shorter, simpler and a bit more efficient.
>
> Reviewed-by: brian m. carlson <sandals@crustytoothpaste.net>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---

Thanks.