From: Junio C Hamano Date: Sun, 02 Aug 2020 20:03:10 GMT Subject: Re: [RESEND PATCH] bisect: use oid_to_hex_r() instead of memcpy()+oid_to_hex() Message-ID: In-Reply-To: <632682d5-e343-c069-f4b4-0451072d54d2@web.de> René Scharfe writes: > Write the hexadecimal object ID directly into the destination buffer > using oid_to_hex_r() instead of writing it into a static buffer first > using oid_to_hex() and then copying it from there using memcpy(). > This is shorter, simpler and a bit more efficient. > > Reviewed-by: brian m. carlson > Signed-off-by: René Scharfe > --- Thanks.