Re: [PATCH 1/2] progress: create progress struct in 'verbose' mode

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 9, 2020, 23:06 UTC
Message-ID: <xmqqzh5ysg71.fsf@gitster.c.googlers.com>
In-Reply-To: <20200909223631.864145-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> I also saw some strbuf manipulation to generate the title, but I also
> don't think that takes significant cycles compared to the task that
> requires the progress display.

I do not think we care so much about cycles. What I find a lot more disturbing was that this loses conceptual clarity (e.g. "why are we generating the title unconditionally when we know we are not going to use it?"), and that is why in the message you are responding to I wondered if this was a price we should accept to pay, as decided to tie the progress and tracing closely earlier.